Skip to content

[UI Tests] Removed the currency code check. #11521

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 16, 2024
Merged

[UI Tests] Removed the currency code check. #11521

merged 2 commits into from
May 16, 2024

Conversation

pachlava
Copy link
Contributor

@pachlava pachlava commented May 15, 2024 •
edited
Loading

Description

This PR addresses two issues:

  1. cad76b1 In certain cases the currency code might not be displayed in the products list. Since this happens in the test env only, it's not considered an issue. More details in p1715691662649999-slack-C6H8C3G23. The fix is removing the check for currency code and the .00 ending in the price:
Screenshot 2024-05-15 at 23 14 35
  1. da431ed A known "Nuage Laboratoire" account issue - [UI Tests] Addressing the Nuage Laboratoire issue and accidental(?) JP banner tap. wordpress-mobile/WordPress-Android#16993 - started taking place in WCAndroid tests too. I attempt a similar fix to address it.
Screenshot 2024-05-15 at 23 12 27

Testing instructions

  • CI is 🟢

@pachlava pachlava requested a review from a team as a code owner May 15, 2024 10:01
@pachlava pachlava added the category: ui tests Related to UI testing. label May 15, 2024
@pachlava pachlava marked this pull request as draft May 15, 2024 10:02
@pachlava pachlava added this to the 19.2 milestone May 15, 2024
@wpmobilebot
Copy link
Collaborator

wpmobilebot commented May 15, 2024 •
edited
Loading

📲 You can test the changes from this Pull Request in WooCommerce Android by scanning the QR code below to install the corresponding build.

App Name WooCommerce Android
FlavorJalapeno
Build TypeDebug
Commitda431ed
Direct Downloadwoocommerce-prototype-build-pr11521-da431ed.apk

@pachlava pachlava marked this pull request as ready for review May 15, 2024 20:15
@pachlava pachlava requested review from tiagomar and jostnes May 15, 2024 20:15
@pachlava pachlava enabled auto-merge May 16, 2024 09:14
jostnes
jostnes approved these changes May 16, 2024
View reviewed changes
Copy link
Contributor

@jostnes jostnes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't run this locally but changes make sense and looks safe. CI is green, :shipit:

@pachlava pachlava merged commit 0916186 into trunk May 16, 2024
17 checks passed
@pachlava pachlava deleted the ui-tests-remove-currencycode branch May 16, 2024 10:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jostnes jostnes jostnes approved these changes

@tiagomar tiagomar Awaiting requested review from tiagomar

Assignees
No one assigned
Labels
category: ui tests Related to UI testing.
Projects
None yet
Milestone
19.2
Development

Successfully merging this pull request may close these issues.
3 participants
@pachlava @wpmobilebot @jostnes